admin/Cites_Plugins
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: split team/player/message into impl/ and exception/ subpackages

Browse Source 
Each domain now has:
- Top-level package: contracts (interfaces, entities, enums, values, events).
- exception/ subpackage: exception hierarchy.
- impl/ subpackage: implementations CR-Core ships by default, swappable by
  a game plugin if needed.

Moved (FQN changes for consumers):
- fr.luc.crcore.team.TeamException (+ AlreadyExists, NotFound, Access)
    → fr.luc.crcore.team.exception.*
- fr.luc.crcore.team.TeamServiceImpl, BukkitEventFiringTeamServiceImpl,
  InMemoryTeamRepository, SqliteTeamRepository
    → fr.luc.crcore.team.impl.*
- fr.luc.crcore.player.PlayerException, PlayerProfileNotFoundException
    → fr.luc.crcore.player.exception.*
- fr.luc.crcore.player.PlayerProfileServiceImpl,
  BukkitEventFiringPlayerProfileServiceImpl,
  InMemoryPlayerProfileRepository, SqlitePlayerProfileRepository
    → fr.luc.crcore.player.impl.*
- fr.luc.crcore.message.YamlMessagesService
    → fr.luc.crcore.message.impl.YamlMessagesService

Unchanged top-level packages: database/, command/, common/ (already small
and well-organized). Events stay where they were (already in event/
subpackages).

setup.md tree updated to reflect the new layout. decisions.md logs the
rationale (consumer-facing FQNs, separation between contract and impl).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Antone Barbaud
2026-06-10 10:54:35 +02:00
parent 4651ccbe69
commit 923f48ffc7
20 changed files with 183 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/fr/luc/crcore/CRCore.java
+7 -7
View File
@@ -3,15 +3,15 @@ package fr.luc.crcore;
import fr.luc.crcore.command.builtin.CoreCommand;
import fr.luc.crcore.database.Database;
import fr.luc.crcore.message.MessagesService;
import fr.luc.crcore.message.YamlMessagesService;
import fr.luc.crcore.player.BukkitEventFiringPlayerProfileServiceImpl;
import fr.luc.crcore.player.InMemoryPlayerProfileRepository;
import fr.luc.crcore.message.impl.YamlMessagesService;
import fr.luc.crcore.player.impl.BukkitEventFiringPlayerProfileServiceImpl;
import fr.luc.crcore.player.impl.InMemoryPlayerProfileRepository;
import fr.luc.crcore.player.PlayerProfileRepository;
import fr.luc.crcore.player.PlayerProfileService;
import fr.luc.crcore.player.SqlitePlayerProfileRepository;
import fr.luc.crcore.team.BukkitEventFiringTeamServiceImpl;
import fr.luc.crcore.team.InMemoryTeamRepository;
import fr.luc.crcore.team.SqliteTeamRepository;
import fr.luc.crcore.player.impl.SqlitePlayerProfileRepository;
import fr.luc.crcore.team.impl.BukkitEventFiringTeamServiceImpl;
import fr.luc.crcore.team.impl.InMemoryTeamRepository;
import fr.luc.crcore.team.impl.SqliteTeamRepository;
import fr.luc.crcore.team.TeamRepository;
import fr.luc.crcore.team.TeamService;
import org.bukkit.Bukkit;
src/main/java/fr/luc/crcore/command/builtin/team/TeamCreateSubCommand.java
+1 -1
View File
@@ -7,7 +7,7 @@ import fr.luc.crcore.command.SubCommand;
import fr.luc.crcore.message.MessagesService;
import fr.luc.crcore.team.Team;
import fr.luc.crcore.team.TeamColor;
import fr.luc.crcore.team.TeamException;
import fr.luc.crcore.team.exception.TeamException;
import fr.luc.crcore.team.TeamService;
import fr.luc.crcore.team.TeamVisibility;
import org.bukkit.entity.Player;
src/main/java/fr/luc/crcore/command/builtin/team/TeamJoinSubCommand.java
+1 -1
View File
@@ -5,7 +5,7 @@ import fr.luc.crcore.command.CommandResult;
import fr.luc.crcore.command.SubCommand;
import fr.luc.crcore.message.MessagesService;
import fr.luc.crcore.team.Team;
import fr.luc.crcore.team.TeamException;
import fr.luc.crcore.team.exception.TeamException;
import fr.luc.crcore.team.TeamService;
import org.bukkit.entity.Player;
src/main/java/fr/luc/crcore/message/YamlMessagesService.java → src/main/java/fr/luc/crcore/message/impl/YamlMessagesService.java
+2 -1
View File
@@ -1,4 +1,5 @@
package fr.luc.crcore.message;
package fr.luc.crcore.message.impl;
import fr.luc.crcore.message.MessagesService;
import org.bukkit.ChatColor;
import org.bukkit.configuration.ConfigurationSection;
src/main/java/fr/luc/crcore/player/PlayerException.java → src/main/java/fr/luc/crcore/player/exception/PlayerException.java
+1 -1
View File
@@ -1,4 +1,4 @@
package fr.luc.crcore.player;
package fr.luc.crcore.player.exception;
public class PlayerException extends RuntimeException {
src/main/java/fr/luc/crcore/player/PlayerProfileNotFoundException.java → src/main/java/fr/luc/crcore/player/exception/PlayerProfileNotFoundException.java
+1 -1
View File
@@ -1,4 +1,4 @@
package fr.luc.crcore.player;
package fr.luc.crcore.player.exception;
public class PlayerProfileNotFoundException extends PlayerException {
src/main/java/fr/luc/crcore/player/BukkitEventFiringPlayerProfileServiceImpl.java → src/main/java/fr/luc/crcore/player/impl/BukkitEventFiringPlayerProfileServiceImpl.java
+7 -1
View File
@@ -1,4 +1,10 @@
package fr.luc.crcore.player;
package fr.luc.crcore.player.impl;
import fr.luc.crcore.player.exception.PlayerProfileNotFoundException;
import fr.luc.crcore.player.exception.PlayerException;
import fr.luc.crcore.player.PlayerProfileRepository;
import fr.luc.crcore.player.PlayerProfileService;
import fr.luc.crcore.player.PlayerRanking;
import fr.luc.crcore.player.PlayerProfile;
import fr.luc.crcore.player.event.PlayerProfileCreateEvent;
import fr.luc.crcore.player.event.PlayerProfileDeleteEvent;
src/main/java/fr/luc/crcore/player/InMemoryPlayerProfileRepository.java → src/main/java/fr/luc/crcore/player/impl/InMemoryPlayerProfileRepository.java
+7 -1
View File
@@ -1,4 +1,10 @@
package fr.luc.crcore.player;
package fr.luc.crcore.player.impl;
import fr.luc.crcore.player.exception.PlayerProfileNotFoundException;
import fr.luc.crcore.player.exception.PlayerException;
import fr.luc.crcore.player.PlayerProfileRepository;
import fr.luc.crcore.player.PlayerProfileService;
import fr.luc.crcore.player.PlayerRanking;
import fr.luc.crcore.player.PlayerProfile;
import java.util.Collection;
import java.util.Collections;
src/main/java/fr/luc/crcore/player/PlayerProfileServiceImpl.java → src/main/java/fr/luc/crcore/player/impl/PlayerProfileServiceImpl.java
+7 -1
View File
@@ -1,4 +1,10 @@
package fr.luc.crcore.player;
package fr.luc.crcore.player.impl;
import fr.luc.crcore.player.exception.PlayerProfileNotFoundException;
import fr.luc.crcore.player.exception.PlayerException;
import fr.luc.crcore.player.PlayerProfileRepository;
import fr.luc.crcore.player.PlayerProfileService;
import fr.luc.crcore.player.PlayerRanking;
import fr.luc.crcore.player.PlayerProfile;
import java.util.ArrayList;
import java.util.Collection;
src/main/java/fr/luc/crcore/player/SqlitePlayerProfileRepository.java → src/main/java/fr/luc/crcore/player/impl/SqlitePlayerProfileRepository.java
+7 -1
View File
@@ -1,4 +1,10 @@
package fr.luc.crcore.player;
package fr.luc.crcore.player.impl;
import fr.luc.crcore.player.exception.PlayerProfileNotFoundException;
import fr.luc.crcore.player.exception.PlayerException;
import fr.luc.crcore.player.PlayerProfileRepository;
import fr.luc.crcore.player.PlayerProfileService;
import fr.luc.crcore.player.PlayerRanking;
import fr.luc.crcore.player.PlayerProfile;
import fr.luc.crcore.database.ColumnType;
import fr.luc.crcore.database.Database;
src/main/java/fr/luc/crcore/team/TeamAccessException.java → src/main/java/fr/luc/crcore/team/exception/TeamAccessException.java
+1 -1
View File
@@ -1,4 +1,4 @@
package fr.luc.crcore.team;
package fr.luc.crcore.team.exception;
public class TeamAccessException extends TeamException {
src/main/java/fr/luc/crcore/team/TeamAlreadyExistsException.java → src/main/java/fr/luc/crcore/team/exception/TeamAlreadyExistsException.java
+1 -1
View File
@@ -1,4 +1,4 @@
package fr.luc.crcore.team;
package fr.luc.crcore.team.exception;
public class TeamAlreadyExistsException extends TeamException {
src/main/java/fr/luc/crcore/team/TeamException.java → src/main/java/fr/luc/crcore/team/exception/TeamException.java
+1 -1
View File
@@ -1,4 +1,4 @@
package fr.luc.crcore.team;
package fr.luc.crcore.team.exception;
public class TeamException extends RuntimeException {
src/main/java/fr/luc/crcore/team/TeamNotFoundException.java → src/main/java/fr/luc/crcore/team/exception/TeamNotFoundException.java
+1 -1
View File
@@ -1,4 +1,4 @@
package fr.luc.crcore.team;
package fr.luc.crcore.team.exception;
public class TeamNotFoundException extends TeamException {
src/main/java/fr/luc/crcore/team/BukkitEventFiringTeamServiceImpl.java → src/main/java/fr/luc/crcore/team/impl/BukkitEventFiringTeamServiceImpl.java
+13 -1
View File
@@ -1,4 +1,16 @@
package fr.luc.crcore.team;
package fr.luc.crcore.team.impl;
import fr.luc.crcore.team.exception.TeamAccessException;
import fr.luc.crcore.team.exception.TeamNotFoundException;
import fr.luc.crcore.team.exception.TeamAlreadyExistsException;
import fr.luc.crcore.team.exception.TeamException;
import fr.luc.crcore.team.TeamRepository;
import fr.luc.crcore.team.TeamService;
import fr.luc.crcore.team.TeamRanking;
import fr.luc.crcore.team.TeamVisibility;
import fr.luc.crcore.team.TeamColor;
import fr.luc.crcore.team.TeamRole;
import fr.luc.crcore.team.TeamMember;
import fr.luc.crcore.team.Team;
import fr.luc.crcore.team.event.PlayerJoinTeamEvent;
import fr.luc.crcore.team.event.TeamCreateEvent;
src/main/java/fr/luc/crcore/team/InMemoryTeamRepository.java → src/main/java/fr/luc/crcore/team/impl/InMemoryTeamRepository.java
+13 -1
View File
@@ -1,4 +1,16 @@
package fr.luc.crcore.team;
package fr.luc.crcore.team.impl;
import fr.luc.crcore.team.exception.TeamAccessException;
import fr.luc.crcore.team.exception.TeamNotFoundException;
import fr.luc.crcore.team.exception.TeamAlreadyExistsException;
import fr.luc.crcore.team.exception.TeamException;
import fr.luc.crcore.team.TeamRepository;
import fr.luc.crcore.team.TeamService;
import fr.luc.crcore.team.TeamRanking;
import fr.luc.crcore.team.TeamVisibility;
import fr.luc.crcore.team.TeamColor;
import fr.luc.crcore.team.TeamRole;
import fr.luc.crcore.team.TeamMember;
import fr.luc.crcore.team.Team;
import java.util.Collection;
import java.util.Collections;
src/main/java/fr/luc/crcore/team/SqliteTeamRepository.java → src/main/java/fr/luc/crcore/team/impl/SqliteTeamRepository.java
+13 -1
View File
@@ -1,4 +1,16 @@
package fr.luc.crcore.team;
package fr.luc.crcore.team.impl;
import fr.luc.crcore.team.exception.TeamAccessException;
import fr.luc.crcore.team.exception.TeamNotFoundException;
import fr.luc.crcore.team.exception.TeamAlreadyExistsException;
import fr.luc.crcore.team.exception.TeamException;
import fr.luc.crcore.team.TeamRepository;
import fr.luc.crcore.team.TeamService;
import fr.luc.crcore.team.TeamRanking;
import fr.luc.crcore.team.TeamVisibility;
import fr.luc.crcore.team.TeamColor;
import fr.luc.crcore.team.TeamRole;
import fr.luc.crcore.team.TeamMember;
import fr.luc.crcore.team.Team;
import fr.luc.crcore.database.ColumnType;
import fr.luc.crcore.database.Database;
src/main/java/fr/luc/crcore/team/TeamServiceImpl.java → src/main/java/fr/luc/crcore/team/impl/TeamServiceImpl.java
+13 -1
View File
@@ -1,4 +1,16 @@
package fr.luc.crcore.team;
package fr.luc.crcore.team.impl;
import fr.luc.crcore.team.exception.TeamAccessException;
import fr.luc.crcore.team.exception.TeamNotFoundException;
import fr.luc.crcore.team.exception.TeamAlreadyExistsException;
import fr.luc.crcore.team.exception.TeamException;
import fr.luc.crcore.team.TeamRepository;
import fr.luc.crcore.team.TeamService;
import fr.luc.crcore.team.TeamRanking;
import fr.luc.crcore.team.TeamVisibility;
import fr.luc.crcore.team.TeamColor;
import fr.luc.crcore.team.TeamRole;
import fr.luc.crcore.team.TeamMember;
import fr.luc.crcore.team.Team;
import org.bukkit.Location;